Open
Conversation
spetrunia
reviewed
Jan 31, 2019
| list(APPEND THIRDPARTY_LIBS aws-cpp-sdk-s3 aws-cpp-sdk-kinesis aws-cpp-sdk-core) | ||
| include_directories(../../aws-sdk-cpp/aws-cpp-sdk-s3/include ../../aws-sdk-cpp/aws-cpp-sdk-kinesis/include ../../aws-sdk-cpp/aws-cpp-sdk-core/include) | ||
| link_directories(../../aws-sdk-cpp/aws-cpp-sdk-s3 ../../aws-sdk-cpp/aws-cpp-sdk-kinesis ../../aws-sdk-cpp/aws-cpp-sdk-core) | ||
| endif() |
There was a problem hiding this comment.
I think we will be able to offer a better way to work with AWS SDK, soon.
There was a problem hiding this comment.
@spetrunia did you made any progress with that ?
|
what's the status of this PR? I basically want to use rocksdb-cloud with a server like minio or equivalent solution. In my understanding this can only be done using that branch. |
|
Hi @benoitc , I believe @spetrunia and @msinyavi have this working, maybe they can post an update here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and missing cloud files to support cmake build with Minio/S3 and Kafka logs using aws-sdk-cpp (built locally, using relative paths to locate) and librdkafka (system library like from stock Ubuntu package).